Gitignore the operator's knowledge store in both shapes bonfire init can create - #259

CONTRACT

bonfire init seeds a .gitignore into every new user's repository. It seeded exactly one line — the per-machine tool scan — and nothing for the knowledge store. An operator who enables a persistent backend and runs git add can therefore stage an index built from their own private source, in a public repo published to public PyPI.

Anta's ruling: the laws and the mechanism travel, the operator's contents never do.

WORLD — the measurement that changed the fix

The store's single default path (src/bonfire/knowledge/__init__.py:24, vault_path=".bonfire/vault") takes two different on-disk shapes:

The obvious pattern, .bonfire/vault/ with a trailing slash, is directory-only and misses the file entirely. Measured against real git, all four combinations:

===== B. trailing slash, SQLITE regular-file shape =====
  rc=1  .bonfire/vault                               <NO MATCH>          <-- THE LEAK
  rc=0  .bonfire/vault/vault_v2.lance/data/0.lance   .gitignore:2:.bonfire/vault/
  rc=1  .bonfire/sessions/handoff.md                 <NO MATCH>
  rc=1  .bonfire/context.json                        <NO MATCH>
  rc=1  .bonfire/costs.jsonl                         <NO MATCH>

===== D. no trailing slash, SQLITE regular-file shape =====
  rc=0  .bonfire/vault                               .gitignore:2:.bonfire/vault
  rc=0  .bonfire/vault/vault_v2.lance/data/0.lance   .gitignore:2:.bonfire/vault
  rc=1  .bonfire/sessions/handoff.md                 <NO MATCH>
  rc=1  .bonfire/context.json                        <NO MATCH>
  rc=1  .bonfire/costs.jsonl                         <NO MATCH>

So the seeded pattern is .bonfire/vault, without the slash. It covers both shapes, and in the same run it over-covers nothing: sessions/, context.json and costs.jsonl stay stageable, because operators commit their session handoffs.

The seed is now:

# Bonfire — operator-local state (do not commit).
.bonfire/tools.local.toml
.bonfire/vault

Stated plainly: this is PREVENTIVE, not a leak being closed

get_vault_backend() has zero production callers — only the factory itself, tests, and a note in src/bonfire/engine/composition.py saying the ingest consumer is deliberately unwired. VaultConfig carries only session_dir and context_file, so no bonfire.toml key selects a backend today. And git ls-tree -r bonfireai/main | grep '^\.bonfire/' returns nothing — no file under .bonfire/ has ever been tracked, so there is nothing to untrack and no published-history question. What this fixes is what every future user inherits.

The pin is strengthened, not retired

The narrowness pin moved into its own module, tests/unit/test_init_gitignore_width.py, because it is now one contract graded in both directions. It:

• grades real git check-ignore against a real repository with the SQLite file shape materialised on disk — the shape the old probe set could not see;
• attributes every verdict to the seeded .gitignore (.gitignore: prefix on -v output), in both directions, so a contributor's global excludes can neither satisfy the positive half nor falsely trip the negative half;
• neutralises git's own config (GIT_CONFIG_GLOBAL / GIT_CONFIG_SYSTEM → os.devnull) on every subprocess, so the test is machine-independent;
• refuses a fatal git exit (assert returncode in (0, 1)) instead of collapsing 128 into "not ignored" — an empty result and a failure no longer look identical;
• closes the seeded set by literal equality against {".bonfire/tools.local.toml", ".bonfire/vault"}, written as literals and never imported from init.py (importing the guarded value is the vacuous-gate pattern). A finite list of probe paths cannot catch a third path added later; set equality can;
• asserts both probe lists are non-empty before iterating them.

One assertion was removed, with its reason written at the spot: the probe for .bonfire/vault/seed.md. Nothing under src/ produces a seed.md — the string occurred in exactly one place in the entire repository, that assertion. It guarded a phantom. Every sessions / context.json / costs.jsonl assertion is intact.

FAILURE — three control rods, each watched going RED

Rod A — does the repo's own new line actually bite? Both shapes, on this tree:

$ git check-ignore -v .bonfire/vault .bonfire/vault/vault_v2.lance/data/0.lance
.gitignore:232:.bonfire/vault	.bonfire/vault
.gitignore:232:.bonfire/vault	.bonfire/vault/vault_v2.lance/data/0.lance
  (exit 0)

--- SQLITE REGULAR FILE at .bonfire/vault ---
$ git check-ignore -v .bonfire/vault
.gitignore:232:.bonfire/vault	.bonfire/vault
  (exit 0)

--- the committable siblings must stay STAGEABLE ---
$ git status --porcelain
?? .bonfire/
$ git check-ignore -v .bonfire/sessions/handoff.md .bonfire/context.json .bonfire/costs.jsonl
  (exit 1 -- 1 means NOT ignored, which is correct)

Rod B — revert the seed to the trailing-slash form. The pin must go red. It does:

E  AssertionError: bonfire init's .gitignore UNDER-covers: '.bonfire/vault' is not
   ignored by the SEEDED .gitignore, so `git add` would stage the operator's own
   content. check-ignore said '' (empty = no pattern matched...)
     # Bonfire — operator-local state (do not commit).
     .bonfire/tools.local.toml
     .bonfire/vault/
FAILED tests/unit/test_init_gitignore_width.py::...::test_seeded_gitignore_covers_operator_state_without_over_covering

Rod C — silently widen the seeded set with a third narrow path no probe touches. The closed-world assertion catches what a probe list cannot:

E  AssertionError: the set of .bonfire entries bonfire init seeds ... changed.
   Expected exactly ['.bonfire/tools.local.toml', '.bonfire/vault'];
   got ['.bonfire/cache/', '.bonfire/tools.local.toml', '.bonfire/vault']
   (added ['.bonfire/cache/'], missing [])

No ratchet was moved

• tests/unit/test_tools_section_is_local.py: 958 → 868, against its frozen 893. The split returns it below its number rather than raising it; the gauge will report shrink slack.
• tests/unit/test_init_gitignore_width.py (new, 284 lines) is declared with a purpose string rather than given a number — the shape the gauge documents for a new file, which exempts it from the package draw while still holding it to the 500-line cap. file-budget.json's diff is 3 added lines and zero deletions.
• cf-file-budget exits 0 on this tree.

Full suite

5778 passed, 3 skipped, 37 xfailed, 20 xpassed. Including the six external pin files that drive _GITIGNORE_LINE and _ensure_gitignore_entry by name — the single-line primitive and the constant both keep their exact shapes for that reason, and it is documented in the code.

🔴 Findings for a maintainer — not fixed here

1. The person-name allowlist is anchored by LINE NUMBER. tests/unit/test_no_persona_names_in_public_docs.py::_ALLOWLIST holds (path, lineno, full_line) tuples. Editing README and CHANGELOG shifted six of them and the pin went red — the registry pointer rotted, not the docs. I re-anchored the six line numbers and touched none of their expected text (the diff is six integers). The anchors should be content-addressed, not positional; that is the same rot this repo already retired from exemptions.json.
2. The README drift-catcher cannot catch this drift. test_readme_quick_start_enumerates_every_created_artefact only checks that four tokens appear in a ±600-char window, so a new artefact can never make it fire, despite its docstring claiming it pins the list. It is also now within ~90 chars of that window sliding.
3. A pre-existing .gitignore already holding .bonfire/vault/ gets .bonfire/vault appended on the next init — harmless (only the new form covers the file) but the file ends with two vault lines. De-duplication would need a pattern-equivalence notion init.py does not have.
4. An empty (0-byte) pre-existing .gitignore takes the append branch and gets a leading blank line and no explanatory header. Pre-existing, byte-stable on re-run.
5. src/bonfire/cli/commands/init.py is at 499 of 500 measured lines. The next change to it must split the module, not compress comments.
6. A LawGiver pre-gate defect, found by running it on this change. It reports FILE_BUDGET_NEW 540 lines > 500 for README.md and 744 > 500 for CHANGELOG.md. Both are false: README was already 539 lines and CHANGELOG 729 at bonfireai/main before this change (which adds 1 and 15 lines), neither is baselined because the shipped gauge walks .py files only — file-budget.json's own notes say exactly that — and cf-file-budget exits 0 on this tree. The pre-gate applies a Python-source size law to markdown and, because markdown is never baselined, reads every long document as a brand-new violation.

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com